Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename OrderIntakeStore::drain_new_orders #341

Closed
ZanCorDX opened this issue Jan 6, 2025 · 3 comments · Fixed by #354
Closed

Rename OrderIntakeStore::drain_new_orders #341

ZanCorDX opened this issue Jan 6, 2025 · 3 comments · Fixed by #354
Assignees
@programskillforverification
Labels
good first issue Good for newcomers

Comments

@ZanCorDX
Copy link
Contributor

ZanCorDX commented Jan 6, 2025

The name choice for OrderIntakeStore::drain_new_orders was poor since it's unclear why it returns None.
We should rename it to try_drain_new_orders_if_no_cancellations which tells you that you get the orders ONLY if we have no cancellations.
@ZanCorDX ZanCorDX added the good first issue Good for newcomers label Jan 6, 2025
@programskillforverification
Copy link
Contributor

Hey! can you assign me this?

@faheelsattar
Copy link
Contributor

if its still up i can pick it up?

Merged
3 tasks
@ZanCorDX
Copy link
Contributor Author

if its still up i can pick it up?

It's done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@programskillforverification programskillforverification

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename OrderIntakeStore::drain_new_orders programskillforverification/rbuilder
3 participants
@faheelsattar @programskillforverification @ZanCorDX