Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fleet-gitops flow is broken for free users (and some premium users) #23050

Closed
getvictor opened this issue Oct 21, 2024 · 3 comments
Closed

fleet-gitops flow is broken for free users (and some premium users) #23050

getvictor opened this issue Oct 21, 2024 · 3 comments
Assignees
Labels
~backend Backend-related issue. ~dogfood Issue resulted from Fleet's product dogfooding. #g-mdm MDM product group ~gitops Related to functionality that enables automation of Fleet via userland git repo(s). :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~released bug This bug was found in a stable release.
Milestone

Comments

@getvictor
Copy link
Member

getvictor commented Oct 21, 2024

I tried following the flow from https://github.com/fleetdm/fleet-gitops using a non-premium Fleet deploy on Render, and hit these issues:

  • The fleet-gitops flow does not work without a ./teams directory or files in the ./teams directory
  • --delete-other-teams switch does not work for free users -- it should be ignored for non-premium users

QA Testplan

The fix for ./teams has already been merged to fleet-gitops repo. @getvictor tested it in a cloned repo: https://github.com/getvictor/fleet-gitops

For --delete-other-teams, run gitops on a free server with that switch, like fleetctl gitops -f default.yml --delete-other-teams

TODO after release

@getvictor getvictor added #g-mdm MDM product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~backend Backend-related issue. ~dogfood Issue resulted from Fleet's product dogfooding. ~gitops Related to functionality that enables automation of Fleet via userland git repo(s). labels Oct 21, 2024
@getvictor getvictor self-assigned this Oct 21, 2024
@getvictor getvictor added the ~released bug This bug was found in a stable release. label Oct 21, 2024
@getvictor
Copy link
Member Author

@getvictor getvictor added this to the 4.59.0-tentative milestone Oct 21, 2024
getvictor added a commit that referenced this issue Oct 21, 2024
#23050
# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [x] Manual QA for all new/changed functionality
@PezHub
Copy link
Contributor

PezHub commented Nov 7, 2024

QA Notes:

I reproduced the undesired error on 4.58.0 -

fleetctl gitops --context=preview -f ~/fleetdm/gitops_configs/default.yml --delete-other-teams                06:56:44 PM
Warning: Version mismatch.
Client Version:  4.54.0
Server Version: 0.0.0-SNAPSHOT-e98f86d
[+] applied fleet config
[+] applied enroll secrets
Error: missing or invalid license

and confirmed once the fix was applied the --delete-other-teams tag was ignored in the free version of preview

fleetctl gitops --context=preview -f ~/fleetdm/gitops_configs/default.yml --delete-other-teams        06:35:53 PM
Warning: Version mismatch.
Client Version:  tf-mod-byo-ecs-v1.8.1-135-g1172f8815-dirty
Server Version: 0.0.0-SNAPSHOT-1172f88
[+] applied fleet config
[+] applied enroll secrets
[!] gitops succeeded

@fleet-release
Copy link
Contributor

In cloud city's code,
Fleet-gitops flow now mends,
Free users find road.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
~backend Backend-related issue. ~dogfood Issue resulted from Fleet's product dogfooding. #g-mdm MDM product group ~gitops Related to functionality that enables automation of Fleet via userland git repo(s). :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~released bug This bug was found in a stable release.
Development

No branches or pull requests

4 participants