Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename and reorder chapters #13

Closed
fraxken opened this issue Nov 17, 2022 · 7 comments
Closed

Rename and reorder chapters #13

fraxken opened this issue Nov 17, 2022 · 7 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@fraxken
Copy link
Owner

fraxken commented Nov 17, 2022

Hello 👋

In order to be able to generate PDF version, we need to order the folders and files (else they will be concatened in the wrong order).

image

I started the work on the french version. It require to fix all the markdown links.

@fraxken fraxken added help wanted Extra attention is needed good first issue Good for newcomers labels Nov 17, 2022
@fraxken
Copy link
Owner Author

fraxken commented Nov 17, 2022

By the way, for testing PDF generation

node .\scripts\generatePdf.js --lang fr

@alexandrecoin
Copy link
Contributor

Hi ! 👋
I'd be happy to give a hand on this.
As you seem to be taking care of the French version, would you like me to do the English one ?

@fraxken
Copy link
Owner Author

fraxken commented Nov 18, 2022

Hello 👋

I gladly accept your help @alexandrecoin! Yes do not hesitate to take care of the English one.

@fraxken
Copy link
Owner Author

fraxken commented Nov 20, 2022

@alexandrecoin If you are motivated you can finish french (I was thinking doing it but I don't have much time in the coming days).

@alexandrecoin
Copy link
Contributor

@fraxken Yes, will do. 👍

@alexandrecoin
Copy link
Contributor

alexandrecoin commented Nov 21, 2022

Before doing so, I noticed there's actually an issue with the links that appear to be broken on both updated French and English versions.

Markdown links between parentheses are rendered as well.
alanshaw/markdown-pdf#212 (comment)

And it looks like paths require to include the chapters directory, otherwise they're a bit off.

Without the chapters directory
Capture d’écran 2022-11-21 à 20 35 46

With the chapters directory
Capture d’écran 2022-11-21 à 20 39 30

Still, the links remain non clickable 🤔

@fraxken
Copy link
Owner Author

fraxken commented Jan 29, 2023

Closing as I finished chapter re-order. Opened an issue for improvment of PDF generation: #18

@fraxken fraxken closed this as completed Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants