From a57f36e3469eebe74a1381ca467120a941765e35 Mon Sep 17 00:00:00 2001 From: Brett Zamir Date: Fri, 17 Jan 2025 18:15:14 +0800 Subject: [PATCH] fix(`valid-types`): update closure suppress types; fixes #1349 (#1350) --- src/rules/validTypes.js | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/rules/validTypes.js b/src/rules/validTypes.js index 8c1839bf3..7e3996e7e 100644 --- a/src/rules/validTypes.js +++ b/src/rules/validTypes.js @@ -24,13 +24,16 @@ const suppressTypes = new Set([ // https://github.com/google/closure-compiler/blob/master/src/com/google/javascript/jscomp/parsing/ParserConfig.properties#L154 'accessControls', 'checkDebuggerStatement', + 'checkEs5InheritanceCorrectnessConditions', 'checkPrototypalTypes', 'checkRegExp', 'checkTypes', 'checkVars', + 'closureClassChecks', 'closureDepMethodUsageChecks', 'const', 'constantProperty', + 'dangerousUnrecognizedTypeError', 'deprecated', 'duplicate', 'es5Strict', @@ -42,6 +45,7 @@ const suppressTypes = new Set([ 'lateProvide', 'legacyGoogScopeRequire', 'lintChecks', + 'lintVarDeclarations', 'messageConventions', 'misplacedTypeAnnotation', 'missingOverride', @@ -49,12 +53,15 @@ const suppressTypes = new Set([ 'missingProperties', 'missingProvide', 'missingRequire', + 'missingReturn', 'missingSourcesWarnings', 'moduleLoad', + 'msgDescriptions', 'nonStandardJsDocs', 'partialAlias', 'polymer', 'reportUnknownTypes', + 'strictCheckTypes', 'strictMissingProperties', 'strictModuleDepCheck', 'strictPrimitiveOperators', @@ -69,6 +76,8 @@ const suppressTypes = new Set([ 'unknownDefines', 'untranspilableFeatures', 'unusedLocalVariables', + + // Not documented? 'unusedPrivateMembers', 'useOfGoogProvide', 'uselessCode',