Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move make_multiproof/insert_leaf/rebuild to be a trait/impl on Node #22

Closed
axic opened this issue Sep 9, 2019 · 4 comments
Closed

Move make_multiproof/insert_leaf/rebuild to be a trait/impl on Node #22

axic opened this issue Sep 9, 2019 · 4 comments

Comments

@axic
Copy link
Contributor

axic commented Sep 9, 2019

No description provided.

@axic axic changed the title Move make_multiproof/insert_leaf/rebuild to be a trait on Node Move make_multiproof/insert_leaf/rebuild to be a trait/impl on Node Sep 9, 2019
@s1na
Copy link
Collaborator

s1na commented Sep 9, 2019

make_multiproof and insert_leaf make sense if the Node is root, I'm not sure about rebuild though.

Alternative: add a Trie struct which has root: Node and define make_multiproof and insert_leaf on that?

@gballet
Copy link
Owner

gballet commented Sep 10, 2019

Redundant with #8 #9 #10, closing

@gballet gballet closed this as completed Sep 10, 2019
@axic
Copy link
Contributor Author

axic commented Sep 12, 2019 •
edited
Loading

@s1na why wouldn't rebuild make sense?

Node::rebuild_from_multiproof(&multiproof) -> Node, just like the ::new function.

@s1na
Copy link
Collaborator

s1na commented Sep 12, 2019

@axic that'll work, you're right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@axic @s1na @gballet