Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HP translation integration #736

Closed
MortenHofft opened this issue Dec 12, 2024 · 0 comments
Closed

HP translation integration #736

MortenHofft opened this issue Dec 12, 2024 · 0 comments
Assignees
Labels
HP parity Required to replace the hosted portals

Comments

@MortenHofft
Copy link
Member

Hosted portals have their own translation dropdown. That works when you just arrive on a page, but with history push the HP menu dropdown will not be updated. And so it will point to a different page.
E.g. user arrive at collection/search. The HP knows that the spanish version should go to /es/collection/search and that is hardcoded at build time into the dropdown content.

But when we then do a history push to a collection detail page like collection/123 then the dropdown will still point to /es/collection/search.

Ideas:
lib emit events that a hp script can pick up on and update the dropdown.

@MortenHofft MortenHofft added the HP parity Required to replace the hosted portals label Dec 12, 2024
@danielvdm2000 danielvdm2000 self-assigned this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HP parity Required to replace the hosted portals
Projects
None yet
Development

No branches or pull requests

2 participants