Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for building Dockerfiles from develop branch of Gaffer #356

Open
GCHQDeveloper314 opened this issue May 14, 2024 · 1 comment
Open
Labels
Docker Issue related to the Docker side of the project enhancement Improvement to existing functionality/feature
Milestone

Comments

@GCHQDeveloper314
Copy link
Member

It would be good to support building images directly from the develop branch of Gaffer.
Originally posted by @GCHQDeveloper314 in #325 (comment)

This isn't possible because the GAFFER_VERSION ARG needs to be both a valid Gaffer version (for copying JAR files) and also a branch name.

git checkout ${GAFFER_VERSION} || git checkout gaffer2-${GAFFER_VERSION} && \

if [ ! -f "/jars/accumulo-store-${GAFFER_VERSION}-iterators.jar" ]; then \

@GCHQDeveloper314 GCHQDeveloper314 added enhancement Improvement to existing functionality/feature Docker Issue related to the Docker side of the project labels May 14, 2024
@GCHQDeveloper314 GCHQDeveloper314 added this to the Backlog milestone May 14, 2024
@tb06904
Copy link
Member

tb06904 commented Jul 17, 2024

There is an alternative to this where instead we could use Maven to download the Gaffer JARs and copy them into the image (how the current gaffer-gremlin image does it). This technically allows develop building as you can clone and locally build Gaffer as a snapshot which will be available in the local Maven repo so could be specified as a version for copying into the image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docker Issue related to the Docker side of the project enhancement Improvement to existing functionality/feature
Projects
None yet
Development

No branches or pull requests

2 participants