Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to stream responses to prevent timeouts #20

Open
RAnders00 opened this issue Feb 6, 2019 · 2 comments
Open

Try to stream responses to prevent timeouts #20

RAnders00 opened this issue Feb 6, 2019 · 2 comments

Comments

@RAnders00
Copy link
Contributor

Some channellogs (forsen e.g.) can grow so big that the request can time out before the server has the response ready for sending. I think it would be quite benefitial if justlog transformed the input line-by-line, writing the transformed lines to the http response as they are generated (streaming), so that the response can start being sent right away after the request is made, and not when the whole file has been transformed in memory.

@gempir
Copy link
Owner

gempir commented Feb 6, 2019

I had something like that in logstv
https://github.com/gempir/logstv-cassandra/blob/master/api/main.go#L146

There its just for json. Do you think this makes sense though? Just a stream parameter than can be passed?

@RAnders00 RAnders00 changed the title All responses should be streamed, or at least the channellogs Try to stream responses to prevent timeouts Jul 21, 2019
@zneix
Copy link
Contributor

zneix commented Jun 22, 2021

Isn't our current implementation covering this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants