Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A005 Module array shadows a Python standard-library module #478

Open
paddyroddy opened this issue Jan 14, 2025 · 4 comments
Open

A005 Module array shadows a Python standard-library module #478

paddyroddy opened this issue Jan 14, 2025 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@paddyroddy
Copy link
Member

Describe the Bug

Picked up by ruff==0.9.1 in #477. For now I have suppressed with # noqa: A005.

To Reproduce

import glass
...

Expected Behaviour

No response

Actual Behaviour

No response

Version In Use

2024.3.dev32+g0b41f16

Additional Context

- Python version:
- Operating system:
@paddyroddy paddyroddy added the bug Something isn't working label Jan 14, 2025
@ntessore
Copy link
Collaborator

Do we care?

@paddyroddy
Copy link
Member Author

@ntessore it's an up-to-you situation. It could cause unwanted issues https://docs.astral.sh/ruff/rules/stdlib-module-shadowing, but if you want to keep it then please close this issue.

@ntessore
Copy link
Collaborator

I realise that it could cause issues in general, but I can vouch for the fact that we are not going to use the stdlib array module 😄

@ntessore
Copy link
Collaborator

That said, if we don't want to override the rule on a case-by-case basis, we can also rename that module to something else. I really don't care!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants