Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test verifying go list of dependencies on cmd/gnoland doesn't contain tests/stdlibs #3585

Open
kristovatlas opened this issue Jan 22, 2025 · 0 comments · May be fixed by #3589
Open

add test verifying go list of dependencies on cmd/gnoland doesn't contain tests/stdlibs #3585

kristovatlas opened this issue Jan 22, 2025 · 0 comments · May be fixed by #3589
Labels
security Security-sensitive issue
Milestone
💡Someday/Maybe

Comments

@kristovatlas
Copy link
Contributor

Description

We have methods on std that are intended to be used for testing, but theoretically they could be misused from VM normal execution, e.g. std.TestSetRealm.

These methods are not currently compiled into the gnoland binary, but to avoid accidental regression in the future, we can add a test to ensure that a go list of dependencies on cmd/gnoland doesn't contain tests/stdlibs.

Suggestion from @ajnavarro and @thehowl.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
security Security-sensitive issue
Projects
🧙‍♂️gno.land core team
Status: Triage
Milestone
💡Someday/Maybe
Development

Successfully merging a pull request may close this issue.

test(cmd/gnoland): add test to ensure to not import tests/stdlibs thehowl/gno
1 participant
@kristovatlas