Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate passing 'fee' from the market to the Kelly calculations #462

Closed
coderabbitai bot opened this issue Oct 3, 2024 · 1 comment
Closed

Evaluate passing 'fee' from the market to the Kelly calculations #462

coderabbitai bot opened this issue Oct 3, 2024 · 1 comment
Assignees
@kongzii

Comments

@coderabbitai
Copy link

coderabbitai bot commented Oct 3, 2024

As discussed in PR #433, we need to evaluate where we should pass fee from the market to the Kelly calculations. See the comment for more context.
@gabrielfior gabrielfior removed their assignment Oct 3, 2024
@kongzii kongzii self-assigned this Oct 11, 2024
@kongzii
Copy link
Contributor

kongzii commented Oct 17, 2024

In review #507

@kongzii kongzii closed this as completed Oct 17, 2024
@coderabbitai coderabbitai bot mentioned this issue Oct 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kongzii kongzii

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gabrielfior @kongzii