Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutable DTOs can't honour equals semantics #687

Open
jimirocks opened this issue Nov 27, 2018 · 2 comments
Open

Mutable DTOs can't honour equals semantics #687

jimirocks opened this issue Nov 27, 2018 · 2 comments

Comments

@jimirocks
Copy link
Contributor

The core concept of gooddata-java - mutable dtos is effectively preventing such objects to have valid equals method. It's a question how this issue should be resolved:

❓ make the DTOs immutable and provide copy constrcutors/builders
❓ stay on the current state - the equals is only implemented on objects which has sensible immutable id
❓ something else

@jimirocks jimirocks added this to the 3.0.0 milestone Nov 27, 2018
@xMort
Copy link
Contributor

xMort commented Nov 27, 2018

I vote for the first option.

@jimirocks
Copy link
Contributor Author

Let's also unify the equals/hashCode style and write it to guidelines

@liry liry removed this from the 3.0.0 milestone Mar 28, 2019
@liry liry added this to the 4.0.0 milestone Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants