Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stored reification table outdated from AMR guidelines #122

Closed
flipz357 opened this issue Oct 25, 2023 · 2 comments
Closed

Stored reification table outdated from AMR guidelines #122

flipz357 opened this issue Oct 25, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@flipz357
Copy link

There has been one or two corrections in the reification table of the guidelines, by Jonas Heinecke and me (e.g., see :poss relation where arg0 and arg1 are switched). Maybe it would be good to write a function that crawls always the latest amr guidelines and tries extract reification rule table, and only then if it doesn't work uses a stored table (and if it does work, potentially issue a warning if the crawled version and the version in store are different)?

I'm kinda having this problem also in Smatchpp (for now I took to manually update the table). I can make a pull request in case I find a neat solution, or maybe you have a better suggestion.

@goodmami goodmami added the bug Something isn't working label Oct 28, 2023
@goodmami
Copy link
Owner

There has been one or two corrections in the reification table of the guidelines, by Jonas Heinecke and me (e.g., see :poss relation where arg0 and arg1 are switched).

Thanks for the heads up, @flipz357. I think this is the relevant context: amrisi/amr-guidelines#261

Maybe it would be good to write a function that crawls always the latest amr guidelines and tries extract reification rule table, and only then if it doesn't work uses a stored table (and if it does work, potentially issue a warning if the crawled version and the version in store are different)?

No, at least not in the library itself. It might be useful to do something like this in a GitHub action on a pull request. But I think this will happen infrequently enough that manual intervention is enough.

@flipz357
Copy link
Author

Yes, you are right, it doesn't happen frequently, so manual should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants