Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Technical nit: Adding Context to Errors #116

Closed
yesenarman opened this issue Jan 5, 2023 · 1 comment · Fixed by #49
Closed

Technical nit: Adding Context to Errors #116

yesenarman opened this issue Jan 5, 2023 · 1 comment · Fixed by #49

Comments

@yesenarman
Copy link
Contributor

The IoError variant of ReadUsernameError enum is not used anymore, after switching to anyhow::Result return type. Perhaps this variant should be removed from the example.
@mgeisler mgeisler mentioned this issue Jan 5, 2023
Merged
@mgeisler
Copy link
Collaborator

mgeisler commented Jan 5, 2023

Hey @yesenarman, thanks for spotting this — there is actually already a PR for this: #49. Thanks for reminding me to finally test and review this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

anyhow: Remove ReadUsernameError::IoError ilyagr/comprehensive-rust
2 participants
@mgeisler @yesenarman