Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert fastNTT to emit mod_arith ops directly #1113

Closed
j2kun opened this issue Nov 23, 2024 · 1 comment · Fixed by #1165
Closed

Convert fastNTT to emit mod_arith ops directly #1113

j2kun opened this issue Nov 23, 2024 · 1 comment · Fixed by #1165

Comments

@j2kun
Copy link
Collaborator

j2kun commented Nov 23, 2024

In #1067 I did something slightly hacky while migrating polynomial-to-standard to use mod_arith ops: for the more complicated parts of the NTT lowerings, instead of lowering to mod_arith ops and types, I inserted conversion ops into and out of mod_arith at the start and end of ntt/intt. This allowed me to complete the polynomial type migration more quickly, but leaves that pass in a strange state where some conversions lower to mod_arith and others convert to arith.

This issue is to finish converting fastNTT to mod_arith.

Copy link

This issue has 3 outstanding TODOs:

This comment was autogenerated by todo-backlinks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant