Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing layer type is easily destructive #570

Open
ceesem opened this issue Apr 5, 2024 · 1 comment
Open

Changing layer type is easily destructive #570

ceesem opened this issue Apr 5, 2024 · 1 comment

Comments

@ceesem
Copy link

ceesem commented Apr 5, 2024

It is possible to change a layer type in the UI after it is already defined and in use. Since the layer type is immediately next to the various tool tabs, it is particularly easy to hit in tools like a graphene segmentation layer, where one often needs to move between different tabs to do work. If you accidentally change the layer type on such a misclick, all of the current settings are reset, which can destroy work. For example, accidentally changing the layer type of a segmentation layer removes all selected IDs and resets the various render settings like opacity.

In general, operation that destroy user work should probably be clearly deliberate and hard to trigger accidentally. I can imagine two solutions for this case, which are non-exclusive:

  1. Have a confirmation dialogue for rare-but-destructive changes like changing the type for a non-fresh layer.
  2. Implement a state-level "Undo," as was done in the older Seung-lab neuroglancer branch.
@jbms
Copy link
Collaborator

jbms commented Apr 6, 2024

I think state-level undo is the best solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants