Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Alpine apk extractor does not correctly extract commit hash #240

Closed
another-rex opened this issue Oct 17, 2024 · 2 comments
Closed

bug: Alpine apk extractor does not correctly extract commit hash #240

another-rex opened this issue Oct 17, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@another-rex
Copy link
Collaborator

The commit extractor is not extracting the correct commit line from the status file:

osv-scalibr/extractor/filesystem/os/apk/extractor.go

Line 169 in c36dd4d

commit := h.Get("c")

It is trying to get the lines that starts with c:<commit-hash>, but instead I think it case-insensitively matched to the C: line instead, which is the file checksum.
@another-rex another-rex added the bug Something isn't working label Oct 17, 2024
@erikvarga
Copy link
Collaborator

With #241 has this been resolved?

@another-rex
Copy link
Collaborator Author

Yes, closing this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erikvarga @another-rex