Skip to content
This repository has been archived by the owner on Jul 8, 2024. It is now read-only.

DV Bulk Editor: Bid Strategy Edit Wont Allow Change of Bid Strategy/Type for Line Items #41

Open
hgrias opened this issue Dec 18, 2020 · 1 comment

Comments

@hgrias
Copy link
Contributor

hgrias commented Dec 18, 2020

In the context of DV360 Bidding Strategies, the following editable values in the sheet/UI are mutually exclusive:

  1. Fixed Bid
  2. Bid Goal
  3. Bid Algorithm

For example, if we wanted to change the bid type from fixed bid to bid goal, we would have to delete the value in the record's Fixed Bid Edit column and add a value to the Auto Bid Goal Edit column. When this happens, we get the following NoneType error as the original value for Fixed Bid Edit is no longer a float, but an empty cell.

Float(row['Fixed_Bid_Edit']) * 100000 TypeError: float() argument must be a string or a number, not 'NoneType'

This prevents the user from changing a Line Item's bid strategy from one to another.

@hgrias
Copy link
Contributor Author

hgrias commented Jan 12, 2021

Possible fix outlined in #42 ; needs review

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant