Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Ability to set isPermaLink="false" for guid #109

Closed
1 task done
AyumuKasuga opened this issue Jan 31, 2024 · 0 comments · Fixed by #107
Closed
1 task done

[FEATURE] Ability to set isPermaLink="false" for guid #109

AyumuKasuga opened this issue Jan 31, 2024 · 0 comments · Fixed by #107

Comments

@AyumuKasuga
Copy link

Is there an existing feature request for this?

  • I have searched the existing feature requests

Is your feature request related to a problem? Please describe.

Currently, if we use not a real URL for <guid> in RSS, we get this message from validation tool: https://validator.w3.org/feed/docs/error/InvalidHttpGUID.html

Describe the solution that you would like.

As I understand we can use a special type for Item.Id (as we use for Link for example), ans allow user to set isPermaLink value. What do you think?

Describe alternatives you have considered.

No response

Anything else?

No response

jlelse pushed a commit to jlelse/feeds that referenced this issue Dec 19, 2024
Adds the optional attribute from the `guid` RSS spec:
https://www.rssboard.org/rss-specification#ltguidgtSubelementOfLtitemgt

This is a breaking change to the `RssItem` struct as `Guid` is now a
struct, not a string.

- Related Issue go-gitea/gitea#28734
- Closes gorilla#78
- Closes gorilla#109 

Signed-off-by: Yarden Shoham <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant