Shared bean cant be read in anymore

[graphefruit]

Thats due to somehow changes that "+" is replaced with " " (space)

[RagingCactus]

The (in my opinion) "proper" fix would be to use URL-safe Base64, where + is replaced by - and / is replaced by _.
It might be a good idea to use this in the future.

[graphefruit]

Thanks for the support.
The issue is that the URL is generated with PROTO-Buff, and I don't know if things could "crash" or don't work anymore

The strange thing is: The url is read correctly, but the URL-Params search is then destroying the "+" into a space, which wasn't before.

[RagingCactus]

The issue is that the URL is generated with PROTO-Buff, and I don't know if things could "crash" or don't work anymore

I'm not talking about the protobuf serialization step, but about the base64 encoding afterwards. I'm talking about line 123 in this example:

Beanconqueror/src/services/shareService/share-service.service.ts

Lines 121 to 123 in 77c0f1e

	const bytes = BeanProto.encode(protoBean).finish();
	const base64String = this.uiHelper.encode(bytes);

uiHelper.encode does "normal" Base64 encoding of the protobuf bytes, see here:

Beanconqueror/src/services/uiHelper.ts

Lines 162 to 164 in 77c0f1e

	public encode(arrayBuffer) {
	return btoa(String.fromCharCode(...new Uint8Array(arrayBuffer)));
	}

Normal Base64 contains + and / characters, which need to be encoded if they are used in URLs. This is why normal Base64 is not considered to be "URL-safe". URL-safe Base64 replaces + with - and / with _, which do not have a special meaning in URLs.

I would propose to use the URL-safe Base64 alphabet instead to prevent other possible breakages in the future (which could be done using two simple .replace() calls). You never know how platforms URL-encode and/or URL-decode your shared URLs and in intent/deeplink handlers. You could keep the current workaround for backwards compatibility, but only generate URL-safe links in the future.

[graphefruit]

Fixed with 8.0.3 in the first place.