Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deflake TestAWSOIDCRequiredVPCSHelper_CombinedSubnetsForAVpcID #50916

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

marcoandredinis
Copy link
Contributor

Instead of creating an entire cluster, just mock the client to return 0 database services (we were not creating any in the cluster anyway).

Fixes #50549

Instead of creating an entire cluster, just mock the client to return 0
database services (we were not creating any in the cluster anyway)
@marcoandredinis marcoandredinis changed the title Deflake TestAWSOIDCRequiredVPCSHelper_CombinedSubnetsForAVpcID Deflake TestAWSOIDCRequiredVPCSHelper_CombinedSubnetsForAVpcID Jan 9, 2025
@github-actions github-actions bot requested review from mvbrock and smallinsky January 9, 2025 17:55
@marcoandredinis marcoandredinis added this pull request to the merge queue Jan 9, 2025
Merged via the queue into master with commit 9c4b162 Jan 9, 2025
43 checks passed
@marcoandredinis marcoandredinis deleted the marco/deflake_check_requiredvpcs branch January 9, 2025 18:35
@public-teleport-github-review-bot

@marcoandredinis See the table below for backport results.

Branch Result
branch/v15 Create PR
branch/v16 Create PR
branch/v17 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestAWSOIDCRequiredVPCSHelper_CombinedSubnetsForAVpcID flakiness
3 participants