Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build system #2

Open
4 of 6 tasks
matyasselmeci opened this issue Jan 27, 2020 · 8 comments
Open
4 of 6 tasks

Update build system #2

matyasselmeci opened this issue Jan 27, 2020 · 8 comments
Assignees

Comments

@matyasselmeci
Copy link

matyasselmeci commented Jan 27, 2020

There are several tasks needed to finish the transfer of ownership of UberFTP to GCT:

@fscheiner
Copy link
Member

@matyasselmeci @msalle
Just checked the network graph for UberFTP and noticed that we so far ignored the develop branch from Jason Alt. We should maybe first include the changes from this branch (which itself include changes from the community) starting with 6cd7446 and then rebase #6 - if needed.

@msalle
Copy link
Member

msalle commented Jul 2, 2020

Good point, I had missed that. I suggest that - since we've already updated the master for the delete issue - that we bring the master in sync with devel: I've created PR #7 for that.
I've also created a new branch autotools_cleanup_rebased which is ready to be used for an updated PR once PR #7 is through.

@fscheiner
Copy link
Member

fscheiner commented Nov 12, 2020

@matyasselmeci @msalle
For RPM packaging:

I adapted the RPM spec file for UberFTP 2.8 from Fedora to our current code base and the OBS successfully builds RPM packages for SUSE (based on 2ea885b 13ce373 ATM) now.

When we have a final UberFTP 2.9 I'll contact Steve Traylen to update the EPEL/Fedora packaging accordingly.

@fscheiner
Copy link
Member

As we're already at it: The current RPM spec file includes a conversion from ISO-8859 to UTF-8. This is due to NCSA's copyright statement as used in the UberFTP source code containing a copyright sign. This renders most files to ISO-8859. If you agree I'd change that to ASCII where possible, by changing the copyright sign to (C) or better (c) as (the license as served from the OSI actually uses (c)). Or do you think "changing" the copyright statement creates a legal problem? :-)

@fscheiner
Copy link
Member

fscheiner commented Apr 29, 2021

Find a matching commit for my above comment here:

fscheiner@f519f20

I created PR #14 for this. => merged as of now

@fscheiner
Copy link
Member

@matyasselmeci, @msalle :
I think I was too early when checking the box for "Update Copyright?" in #2 (comment) because the idea to replace the copyright symbols with ASCII text versions actually came later.

Was the original idea of that "task" to update the copyright for:

...and the files that have a copyright notice and that were modified by our commits?

But I think we don't do that for the GCT. And I also couldn't find any other copyright notices in the sources than from NCSA, although for example the IPv6 changes from @prelz were substantial.

@msalle
Copy link
Member

msalle commented Apr 29, 2021

Yes, that was the intention. I think it would be good to also include @ellert in this (being the expert).

@fscheiner
Copy link
Member

Yes, that was the intention. I think it would be good to also include @ellert in this (being the expert).

Indeed, @ellert, what's your opinion on #2 (comment)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants