-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strange behavior of changing working directory. #146
Comments
@sttk that is strange, indeed. Do you think we need to make a change in liftoff? |
@phated I think this find-up behavior is helpful when a user works in a directory which is a sub directory but not a sub project of a project, so I think we need not change liftoff. It would be enough to add the real current directory (= I think it's good that the entry order of this directory is the last because a config file in this diretory should be given the most priority. |
I'm good with this solution. |
@sttk still planning to fix this? |
@phated I've just merged v2.0.1 to my repository, and I'm going to address this issue from now. |
I found a strange behavior about changing working directory. This is related to the comment in #109.
Assuming directory structure:
and the contents of each files:
In this condition, the following execution uses
project/gulpfile.js
against my intention.When
project/gulpfile.js
is removed or renamed,project/currentdir/gulpfile-2.js
is used along my intention.This cause is that gulp found up
project/gulpfile.js
andchangedchangedcwd
toproject/
before finding and applying config files.cwd
for finding a config file toproject/
in liftoff.I think when a gulpfile is specified in a config file,I think thatcwd
should be set back toINIT_CWD
or set to parent directory of the gulpfile.process.INIT_CWD
should be added to the directories for finding config files.EDIT: I modified the last two sentences.
The text was updated successfully, but these errors were encountered: