-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variable mapping table and the catalog file #233
Comments
Thanks for the suggestions! It seems that the 2nd item is easiest to implement. Please go ahead and provide a working example. The first and third items look more involved. How do you envisage accomplishing them? Are they needed now or for future releases with support for more models? For the final item: How does this change current functionality? |
The hardest one to implement is probably number 3. There really are a lot of configurations to fill in when creating a new dataset, and the easiest way to do it is debatable. No.1 can be implemented easily with some word2vec packages (it's also not hard to implement without them). As for No.4, I think an alternative to calling the set_alias and manipulate_coords is to print out a reminder or raise a warning: "This dataset is missing XG (the longitude of U-velocity). Some methods may require these variable(s) to work. Called set_alias or manipulate_coords to fill it in. " I would suggest those changes be made before the next release. Right now, the datasets files that have a catalog file are all renamed in the MITgcm fashion (I don't know how it was done, but I assume by hand). Although those changes are going to require somewhere between 100-500 lines of code (actually not that much), I think it is going to help broadcast the package to a much broader audience. I think it is pretty cost-effective. |
Inspired by this issue and #274, we should be able to add function to |
See also @malmans2 2nd comment here: #224 (comment) |
I found opening and working on new datasets that are not in the standard MITgcm output format with oceanspy somewhat difficult.
I am suggesting several functionalities that might come in handy:
The text was updated successfully, but these errors were encountered: