Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VR-Only Config Option #316

Closed
hammy275 opened this issue Oct 25, 2023 · 1 comment
Closed

VR-Only Config Option #316

hammy275 opened this issue Oct 25, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@hammy275
Copy link
Owner

hammy275 commented Oct 25, 2023

Not sure why I haven't made this an option before, but this option (disabled by default) would shut off all ImmersiveMC features while out of VR when enabled.

A way I could implement this:

When ImmersiveMC disables itself
- Keeping this value in the ServerPlayerConfig, so the server knows to stop doing things. Could implement requests to get a player's config to return the default "disabled" config.
- Do all things done when leaving a world, then returning early at the top of render() and at the top of tick() if the player still isn't in VR (re-enabling everything if they hop into it).
- Load the "off"/"disabled" config.
- Special handling for the Mixins.

The above is WAY over-engineered. ImmersiveMC should already support enabling and disabling itself on the fly (pending #327 being fixed). Just disable it out of VR and re-enable entering VR.

Note that MC VR API can't detect whether the user is in VR or not on the title screen, so that will have to be addressed. That should come with hammy275/mc-vr-api#14

@hammy275 hammy275 added the enhancement New feature or request label Oct 25, 2023
@hammy275 hammy275 modified the milestones: Version 1.5.0, 1.4.1 Oct 25, 2023
@hammy275
Copy link
Owner Author

Done! I think there's a small bug where the config change from OFF -> ON isn't acknowledged, but a game restart I believe fixes it.

Other than that, this is done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant