This repository has been archived by the owner on Mar 21, 2019. It is now read-only.
If user exists redirect to refer-a-friend page #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if user already exists redirect to refer and update cookie it also changes the email to lowercase, user that sign up with mobile browser often use Capitalised emails, so it is important, to lower case them for this feature
phamdt
reviewed
Jun 27, 2017
| email = params[:user][:email].downcase | ||
| params[:user][:email] = email | ||
| user = User.find_by_email(email) | ||
| if not user.nil? |
There was a problem hiding this comment.
isn't there a truthy version of this? possibly user.exists?
There was a problem hiding this comment.
also, while i'm not the maintainer, i'm sure it'd be appreciated if there was a unit test or two for this :)
There was a problem hiding this comment.
makes sense thanks for the review, i would like someone with merging powers to let me know if they would be happy to merge this in before adding more code :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes people use a different computer or cleared cookies. For what ever reason the cookie is not there, they want to see their progress or fetch referral link. This pr adds a
before_action :createmethod that will redirect them to the page if they subscribed before. previously a create error would be thrown onuser.saveit also changes the email to lowercase, user that sign up with mobile browser often use Capitalised, emails, so it is important, to lowercase them for this feature to work.
i also fixed a deprecation