Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Failed-Request-Alert-Tuning] Assign Appropriate HTTP Status Code for Immature Records error #3392

Open
Tracked by #3344
quiet-node opened this issue Jan 15, 2025 · 0 comments · May be fixed by #3394
Open
Tracked by #3344
Assignees
Labels
internal For changes that affect the project's internal workings but not its outward-facing functionality.
Milestone

Comments

@quiet-node
Copy link
Member

quiet-node commented Jan 15, 2025

Description

The error caused by immature records in the Mirror Node (MN) is currently returning an HTTP 500 status code. This triggers the failed-request-too-high alerts unnecessarily, making it difficult to identify and prioritize critical issues. Since this scenario is expected behavior and not indicative of a server error, it should use a more appropriate HTTP status code.

This change will ensure that alerts are only triggered for critical issues while maintaining visibility of immature record occurrences through metrics for observability.

Solution
• Define a dedicated error type specifically for scenarios involving immature records.
• Update the HTTP status code for the “immature records found” error to 502 (Bad Gateway) instead of 500.

@quiet-node quiet-node self-assigned this Jan 15, 2025
@quiet-node quiet-node added the enhancement New feature or request label Jan 15, 2025
@quiet-node quiet-node added internal For changes that affect the project's internal workings but not its outward-facing functionality. and removed enhancement New feature or request labels Jan 15, 2025
@quiet-node quiet-node moved this from Backlog to Tasks In Progress in Smart Contract Sprint Board Jan 15, 2025
@quiet-node quiet-node modified the milestones: 0.64.0, 0.64.1 Jan 15, 2025
@quiet-node quiet-node moved this from Tasks In Progress to In Review in Smart Contract Sprint Board Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal For changes that affect the project's internal workings but not its outward-facing functionality.
Projects
Status: In Review
1 participant