From 5fd97919bd29ecf76bf4fe2b5adff8d2285279f6 Mon Sep 17 00:00:00 2001
From: jgotoh <18658140+jgotoh@users.noreply.github.com>
Date: Sat, 20 May 2023 12:53:20 +0200
Subject: [PATCH] Use runParseResult in ParsecTests

---
 .../ProjectConfig/ParsecTests.hs              | 19 +++++++------------
 .../source-repository-packages/cabal.project  | 10 ++++++++++
 2 files changed, 17 insertions(+), 12 deletions(-)
 create mode 100644 cabal-install/tests/IntegrationTests2/ProjectConfig/files/source-repository-packages/cabal.project

diff --git a/cabal-install/tests/IntegrationTests2/ProjectConfig/ParsecTests.hs b/cabal-install/tests/IntegrationTests2/ProjectConfig/ParsecTests.hs
index 3d61324de4a..3e45ad7ee9e 100644
--- a/cabal-install/tests/IntegrationTests2/ProjectConfig/ParsecTests.hs
+++ b/cabal-install/tests/IntegrationTests2/ProjectConfig/ParsecTests.hs
@@ -2,6 +2,7 @@
 module IntegrationTests2.ProjectConfig.ParsecTests (parserTests) where
 
 import qualified Data.ByteString as BS
+import Data.Either
 import Distribution.Client.DistDirLayout
 import Distribution.Client.HttpUtils
 import Distribution.Client.ProjectConfig
@@ -12,14 +13,13 @@ import Distribution.Types.CondTree (CondTree (..))
 import Distribution.Types.PackageName
 import Distribution.Types.PackageVersionConstraint (PackageVersionConstraint (..))
 import Distribution.Types.SourceRepo (KnownRepoType (..), RepoType (..))
-import Distribution.Types.Version (Version, mkVersion)
+import Distribution.Types.Version (mkVersion)
 import Distribution.Types.VersionRange.Internal (VersionRange (..))
 import Distribution.Verbosity
 import System.Directory
 import System.FilePath
 import Test.Tasty
 import Test.Tasty.HUnit
-import Test.Tasty.Options
 
 -- TODO create tests:
 -- - parser tests to read and compare to expected values
@@ -81,12 +81,8 @@ testExtraPackages = do
 readConfigDefault :: FilePath -> IO (ProjectConfigSkeleton, ProjectConfigSkeleton)
 readConfigDefault rootFp = readConfig rootFp "cabal.project"
 
--- TODO this is an overkill, look at warningTests, they just use runParseResult without
--- httpTransport etc
 readConfig :: FilePath -> FilePath -> IO (ProjectConfigSkeleton, ProjectConfigSkeleton)
 readConfig rootFp projectFileName = do
-  -- TODO extract argument so it can be mocked
-  httpTransport <- configureTransport verbosity [] Nothing
   projectRootDir <- canonicalizePath (basedir </> rootFp)
 
   let projectRoot = ProjectRootExplicit projectRootDir projectFileName
@@ -96,9 +92,11 @@ readConfig rootFp projectFileName = do
       distProjectConfigFp = distProjectFile distDirLayout extensionName
   exists <- doesFileExist distProjectConfigFp
   assertBool ("projectConfig does not exist: " <> distProjectConfigFp) exists
-  parsec <-
-    runRebuild projectRootDir $
-      readProjectFileSkeleton verbosity httpTransport distDirLayout extensionName extensionDescription
+  contents <- BS.readFile distProjectConfigFp
+  let (_, res) = runParseResult $ parseProjectSkeleton contents
+  assertBool ("should parse successfully: " ++ show res) $ isRight res
+  let parsec = fromRight undefined res
+  httpTransport <- configureTransport verbosity [] Nothing
   legacy <-
     runRebuild projectRootDir $
       readProjectFileSkeletonLegacy verbosity httpTransport distDirLayout extensionName extensionDescription
@@ -118,9 +116,6 @@ assertConfig expected config configLegacy access = do
     actualLegacy = access configLegacy
 
 -- | Test Utilities
-emptyProjectConfig :: ProjectConfig
-emptyProjectConfig = mempty
-
 verbosity :: Verbosity
 verbosity = normal -- minBound --normal --verbose --maxBound --minBound
 
diff --git a/cabal-install/tests/IntegrationTests2/ProjectConfig/files/source-repository-packages/cabal.project b/cabal-install/tests/IntegrationTests2/ProjectConfig/files/source-repository-packages/cabal.project
new file mode 100644
index 00000000000..1ab7d417b54
--- /dev/null
+++ b/cabal-install/tests/IntegrationTests2/ProjectConfig/files/source-repository-packages/cabal.project
@@ -0,0 +1,10 @@
+source-repository-package
+    type: git
+    location: https://example.com/Project.git
+    tag: 1234
+
+source-repository-package
+    type: git
+    location: https://example.com/example-dir/
+    tag: 12345
+    subdir: subproject