Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor remaining code to use *at APIs #183

Open
Rufflewind opened this issue Jul 15, 2024 · 0 comments
Open

Refactor remaining code to use *at APIs #183

Rufflewind opened this issue Jul 15, 2024 · 0 comments
Labels
type: b-cleanup Cleanup / refactoring changes.

Comments

@Rufflewind
Copy link
Member

With the changes in 14f5851 we could try refactoring some of the other functionality to also use similar *at OS APIs.

-getDirectoryContentsInternal (OsString path) =
+getDirectoryContentsInternal path =
-  bracket (Posix.openDirStream path) Posix.closeDirStream
+  bracket (openRawHandle FollowLinks Nothing path) closeRawHandle readDirHandle

-removePathInternal True  = Posix.removeDirectory . getOsString
+removePathInternal True = removePathAt Directory Nothing

-removePathInternal False = Posix.removeLink . getOsString
+removePathInternal False = removePathAt File      Nothing

 getSymbolicLinkMetadata ...
 getFileMetadata ...

 etc
@Rufflewind Rufflewind added the type: b-cleanup Cleanup / refactoring changes. label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: b-cleanup Cleanup / refactoring changes.
Projects
None yet
Development

No branches or pull requests

1 participant