Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce classname conflict potential by introducing BEM or something similar #675

Open
patricekaufmann opened this issue Dec 8, 2022 · 0 comments
Open

Reduce classname conflict potential by introducing BEM or something similar #675

patricekaufmann opened this issue Dec 8, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@patricekaufmann
Copy link

The class names are very generic at the moment. Classes like `select-item, search, options, panel-content, select-panel, dropdown-heading, dropdown-content' etc. are not very specific and could lead to conflicts in projects with a larger scope.

Class names like rmsc__options would help encapsulating the classes. It would also help avoiding nested selectors like .rmsc .dropdown-content .panel-content as this only costs performance when evaluating css; rmsc__panel-content would probably be sufficient.

What do you think?
@patricekaufmann patricekaufmann added the enhancement New feature or request label Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@patricekaufmann