Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a fixed application size #2681

Open
Andrew1988123123 opened this issue Dec 13, 2024 · 4 comments · May be fixed by #2746
Open

Set a fixed application size #2681

Andrew1988123123 opened this issue Dec 13, 2024 · 4 comments · May be fixed by #2746
Assignees
Labels
desktop Issues related to the desktop enhancement New feature or request
Milestone

Comments

@Andrew1988123123
Copy link

Is your feature request related to a problem? Please describe the impact that the lack of the feature requested is creating.

After starting application, I have to set application size again with Zoom in/out buttons. Reset Zoom button is not an option for me because application is still not properly adjusted. Problem occurs only on desktop application.

Describe the solution you'd like

Add a button that save application size.

What users will benefit from this feature?

User will not have to set application size every time.

Are you able to implement this feature?

No

Additional context

Add button here
image

@Andrew1988123123 Andrew1988123123 added the enhancement New feature or request label Dec 13, 2024
@dosubot dosubot bot added the desktop Issues related to the desktop label Dec 13, 2024
@joaquimrocha
Copy link
Collaborator

Rather than a button, we should remember the zoom after restarts.

@joaquimrocha joaquimrocha added this to the v0.28.0 milestone Jan 7, 2025
skoeva added a commit that referenced this issue Jan 13, 2025
This change adds a new environment variable "ZOOM_LEVEL" to remember the
zoom level in the Electron app after restarts.

Fixes: #2681

Signed-off-by: Evangelos Skopelitis <[email protected]>
@skoeva skoeva linked a pull request Jan 13, 2025 that will close this issue
3 tasks
@skoeva skoeva linked a pull request Jan 13, 2025 that will close this issue
3 tasks
skoeva added a commit that referenced this issue Jan 13, 2025
This change adds a new environment variable "ZOOM_LEVEL" to remember the
zoom level in the Electron app after restarts.

Fixes: #2681

Signed-off-by: Evangelos Skopelitis <[email protected]>
@joaquimrocha
Copy link
Collaborator

joaquimrocha commented Jan 13, 2025

@Andrew1988123123 I have just tried this on our main branch on WSL and it did remember the zoom after I changed it and restarted the app. Can you give us more info about your environment? What version of Headlamp and what platform (Mac, Windows, Flatpak, etc.)?

Nevermind. I was trying the app in a way where somehow the zoom was remembered, I will relay this info to @skoeva but you are right that it doesn't keep the zoom.

@joaquimrocha
Copy link
Collaborator

@Andrew1988123123 Nevermind my previous comment. I updated it.

@skoeva
Copy link
Contributor

skoeva commented Jan 14, 2025

Tested with the dev app, the zoom is kept because it's linked to devtools. The zoom persisted after restarting my entire machine and reset when I hit Ctrl + 0. Not sure if this behavior can be synced with the main app but noticing some bugs with the changes to the app code, looking into this

skoeva added a commit that referenced this issue Jan 15, 2025
This change refactors the zoom functionality in the Electron app to
remember the zoom level in the Electron app after restarts.

Fixes: #2681

Signed-off-by: Evangelos Skopelitis <[email protected]>

change
skoeva added a commit that referenced this issue Jan 15, 2025
This change refactors the zoom functionality in the Electron app to
remember the zoom level in the Electron app after restarts.

Fixes: #2681

Signed-off-by: Evangelos Skopelitis <[email protected]>

change
@skoeva skoeva moved this from Queued to In Progress in Release Plan / Roadmap Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Issues related to the desktop enhancement New feature or request
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

3 participants