Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand JS dict #6

Open
heckerfr0d opened this issue Oct 3, 2021 · 9 comments
Open

Expand JS dict #6

heckerfr0d opened this issue Oct 3, 2021 · 9 comments
Labels
beginner good first issue Good for newcomers hacktoberfest PRs count toward Hacktoberfest

Comments

@heckerfr0d
Copy link
Owner

heckerfr0d commented Oct 3, 2021

Anyone can contribute. Just head on to gitfitti and follow the instructions to help us expand our JS dictionary. PRs are auto-generated on providing Personal Access Token.

Go ahead and add lowercase letters, numbers, and anything else you think we're missing 😇

@heckerfr0d heckerfr0d added good first issue Good for newcomers beginner hacktoberfest PRs count toward Hacktoberfest labels Oct 3, 2021
@REX51
Copy link

REX51 commented Oct 16, 2021

Hi @heckerfr0d
I added to the list in gitfitti with username - access token, but not sure how the PR is being generated. Can you explain it to me?

@heckerfr0d
Copy link
Owner Author

heckerfr0d commented Oct 17, 2021

Hi @REX51 :)
How it works is, the flask app modifies its copy of the javascript file to include the new addition and then uses GitHub's API to fork the repo, make the same modification in your fork of the repo and then submit a PR with the change. It is for this reason that an Access Token with repo scope is required.

UPDATE: The issue was due to some file paths being incorrect in the code. Sorry for the inconvenience :")
Please try again now, it should work :)

@Pavithradevadiga
Copy link
Contributor

Hey i still see the below erro
errorpng
r

@heckerfr0d
Copy link
Owner Author

Hii, thank you for your contribution!
It has worked and I have merged your pull request.
Could you tell me what the URL was when you saw this error page?

@Pavithradevadiga
Copy link
Contributor

Hi @heckerfr0d , I tried again and this is the link (https://gitfitti.herokuapp.com/contribute) with the error.
error

@heckerfr0d
Copy link
Owner Author

Hi @Pavithradevadiga
Please tell me how to reproduce this issue 😅
Like, maybe a list of steps?
I tried making a contribution using another account but I'm not getting this error :")
image

@Pavithradevadiga
Copy link
Contributor

Yeah.

  • So I just opened the gitfitti link
  • Created a simple symbol.
  • Named it,added an alias,username and access token
  • Clicked on Save
  • And BAM i get the error even though the pull request is created :(

I tried reproducing the error again what i observed was I am not facing the error when only "Translate Text to Graffitti" and "Alias" and "username" are selected, it's happening when I give personal access token

@heckerfr0d
Copy link
Owner Author

Hi @Pavithradevadiga
Thank you for the detailed bug report. We've determined that this weird error only appears when using mobile network and is because the request somehow gets interrupted. As a workaround, we've switched from gunicorn to waitress for serving the web app and the bug has been fixed (hopefully 🤞 - please confirm lol).
Thank you for your help in making our software better ☺️

@Pavithradevadiga
Copy link
Contributor

Yep,it's resolved .The pull request has been created without any error.

I am Glad I was of help :")(tears of happiness).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner good first issue Good for newcomers hacktoberfest PRs count toward Hacktoberfest
Projects
None yet
Development

No branches or pull requests

3 participants