Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When editing the protos, tests will not be run #852

Open
PaulKalho opened this issue Oct 4, 2024 · 0 comments
Open

When editing the protos, tests will not be run #852

PaulKalho opened this issue Oct 4, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@PaulKalho
Copy link
Member

PaulKalho commented Oct 4, 2024 •
edited
Loading

Describe the bug

When I was evaluating the usage of dive validator, I had to change some protos of the property-svc.

These changes did break some tests. However, these test are not beeing run in the PR itself.

Describe how to produce the bug

  1. Change protos of property-svc that break the tests.
  2. protos.sh property-svc and git push
  3. checks will not fail, no tests will be run

Additional context

No response
@PaulKalho PaulKalho added the bug Something isn't working label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PaulKalho