Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle switch from desktop to mobile and the other way around on artwork page #575

Open
DPhuongHda opened this issue Jul 6, 2021 · 0 comments
Labels
medium priority Should be implemented mobile This issue is related to the mobile layout User Interface Issue related to the User Interface

Comments

@DPhuongHda
Copy link
Collaborator

DPhuongHda commented Jul 6, 2021

Reason (Why?)

Currently if you switch from desktop to mobile view (window resize) all eight images of the slide are still shown. Obviously the mobile-common-tags feature doesn't work correctly in this case, since it only makes sense if one image per slide is shown.
To fix this view you would have to reload the website to only display one image.

On the other hand if you switch from mobile to desktop view (happens rarely on mobile but maybe some people do this) since only one picture is displayed per slide on mobile the same applies to the desktop view. Again - only reload of the page renders the carousel-slides correctly again.

resize

Solution (What?)

  • One way could be to use events to catch the view change and handle the slides correctly

Acceptance criteria

  • Desktop to mobile view: only one image per slide
  • Mobile to desktop view: display eight images per slide
@DPhuongHda DPhuongHda added medium priority Should be implemented User Interface Issue related to the User Interface mobile This issue is related to the mobile layout labels Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium priority Should be implemented mobile This issue is related to the mobile layout User Interface Issue related to the User Interface
Projects
None yet
Development

No branches or pull requests

1 participant