Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support EditorConfig as inputs #54

Closed
toastal opened this issue Dec 7, 2024 · 1 comment · Fixed by #57
Closed

Support EditorConfig as inputs #54

toastal opened this issue Dec 7, 2024 · 1 comment · Fixed by #57

Comments

@toastal
Copy link

toastal commented Dec 7, 2024

I would like to see EditorConfig be used as a fallback for the default spacing when no format values are specified.

Advantages: keep indentation config in one place; no desync in config/execution; no need to pass arguments or override; ability to specify different values for different files/directories if needed for vendored third-party files

Disadvantages: requires parsing .editorconfig, a third-party format & would incur additional dependencies; minor endorsement of EditorConfig as a project since it would get special support

See response: kdl-org/kdl-rs#96 (comment)

@hougesen
Copy link
Owner

Good idea!

#55 added support for specifying indentation level using a custom kdlfmt config file. Adding fallback support for editorconfig should be pretty straightforward 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants