Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update checkout action to v4 to avoid node deprecation (and inform downstream) #21

Closed
zkamvar opened this issue Aug 1, 2024 · 1 comment · Fixed by #22
Closed

Update checkout action to v4 to avoid node deprecation (and inform downstream) #21

zkamvar opened this issue Aug 1, 2024 · 1 comment · Fixed by #22
Assignees

Comments

@zkamvar
Copy link
Member

zkamvar commented Aug 1, 2024

When I was working on #20, I noticed this deprecation warning:

The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

We should update these workflows and inform the downstream repositories that they also need to update their workflows.

@annakrystalli
Copy link
Member

Sure thing.

Once updated, you could send your first email to the community through our mailing list if you wanted! 😃

Once our workflows have been updated, folks can use hubCI package to re-install the updated versions of workflows.

Also, if we're going to be updating our workflows, what are your thoughts on this comment I added to the #20 PR review?

Follow up question regarding installing our packages in workflows. Until they are on CRAN but given we now have an r-universe, should we be using that to install from instead of GitHub for the time being?

If we want to change the source of our packages, might be a good opportunity to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants