Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about minimum value for cdf #113

Closed
elray1 opened this issue Oct 31, 2024 · 1 comment
Closed

Question about minimum value for cdf #113

elray1 opened this issue Oct 31, 2024 · 1 comment
Labels
higher priority work to prioritize in the near future v4.0.0

Comments

@elray1
Copy link
Contributor

elray1 commented Oct 31, 2024

Looking at the schema for this line:

"minimum": 0

I'm not entirely sure what that minimum of 0 encodes -- is it saying that the output_type_ids for cdf model outputs must be at least 0 (if they are numeric)? If so, I think we should take that requirement out. Most disease forecasting systems would probably be set up with targets that are like "number of hospitalizations", in which case a minimum of 0 makes sense. But in principle, someone could have a different target like "change in number of hospitalizations", in which case negative values might be reasonable, corresponding to a decrease in hospitalizations.

Again, I'm not totally clear on what that entry is specifying, so please correct me if the above interpretation is wrong!

@annakrystalli
Copy link
Member

Yes your interpretation of the minimum is correct and indeed, if negative cdf output type IDs are possible, this should definitely be removed!

@annakrystalli annakrystalli added v4.0.0 higher priority work to prioritize in the near future labels Nov 1, 2024
@annakrystalli annakrystalli moved this from Todo to Up Next in hubverse Development overview Nov 1, 2024
@annakrystalli annakrystalli moved this from Up Next to Reviewed/Ready to Merge in hubverse Development overview Nov 1, 2024
@github-project-automation github-project-automation bot moved this from Reviewed/Ready to Merge to Done in hubverse Development overview Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
higher priority work to prioritize in the near future v4.0.0
Projects
Development

No branches or pull requests

2 participants