Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only allow a single target_keys key value pair #117

Closed
annakrystalli opened this issue Dec 16, 2024 · 2 comments · Fixed by #118 or #119
Closed

Only allow a single target_keys key value pair #117

annakrystalli opened this issue Dec 16, 2024 · 2 comments · Fixed by #118 or #119
Assignees
@annakrystalli
Labels
v4.0.1

Comments

@annakrystalli
Copy link
Member

When we began thinking about target metadata, we allowed for target keys to be able to span multiple columns. We have now decided that this represents unnecessary complexity that is not being used.

Moving forward the schema will restrict target keys to a single key value pair
@annakrystalli annakrystalli moved this from Todo to Up Next in hubverse Development overview Dec 16, 2024
annakrystalli added a commit that referenced this issue Dec 17, 2024
@annakrystalli
Restricted the target_keys object to contain only a single key valu…
0afa40e 
…e pair. Resolves #117
This was referenced Dec 18, 2024
Closed
Merged
Merged
@annakrystalli annakrystalli linked a pull request Dec 18, 2024 that will close this issue
Restrict target_keys object to contain only a single key value pair. #118
Merged
@annakrystalli annakrystalli moved this from Up Next to Ready for Review in hubverse Development overview Dec 18, 2024
@annakrystalli annakrystalli self-assigned this Dec 18, 2024
@annakrystalli annakrystalli mentioned this issue Jan 17, 2025
Merged
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in hubverse Development overview Jan 17, 2025
@zkamvar
Copy link
Member

zkamvar commented Jan 20, 2025 •
edited
Loading

Note for posterity, this decision also removed the target_variable and target_outcome standard task ID properties in 54c8c3e

@annakrystalli
Copy link
Member Author

Good point! I'll update the NEWS and release notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@annakrystalli annakrystalli

Labels
v4.0.1
Projects
hubverse Development overview
Status: Done
Milestone
No milestone
2 participants
@zkamvar @annakrystalli