Artifacts and flickers after update

[arsenez2006]

Already reported ? *

• I have searched the existing open and closed issues.

Regression?

Definitely a regression - something broke after update (requires bisect)

System Info and Hyprland Version

System/Version info

Hyprland 0.46.0 built from branch main at commit c9822b08f914da2997e8ef47c8bef8016e5ff313  (keybinds: add new window destruction dispatchers (8962)).
Date: Wed Jan 8 21:16:34 2025
Tag: v0.46.0-96-gc9822b08, commits: 5651
built against:
 aquamarine 0.6.0
 hyprlang 0.6.0
 hyprutils 0.3.3
 hyprcursor 0.1.11
 hyprgraphics 0.1.1


no flags were set


System Information:
System name: Linux
Node name: arsen.introvert.nepozer.alkash
Release: 6.12.8-arch1-1
Version: #1 SMP PREEMPT_DYNAMIC Thu, 02 Jan 2025 22:52:26 +0000


GPU information: 
00:02.0 VGA compatible controller [0300]: Intel Corporation UHD Graphics 620 [8086:5917] (rev 07) (prog-if 00 [VGA controller])
00:13.0 Non-VGA unclassified device [0000]: Intel Corporation Sunrise Point-LP Integrated Sensor Hub [8086:9d35] (rev 21)


os-release: NAME="Arch Linux"
PRETTY_NAME="Arch Linux"
ID=arch
BUILD_ID=rolling
ANSI_COLOR="38;2;23;147;209"
HOME_URL="https://archlinux.org/"
DOCUMENTATION_URL="https://wiki.archlinux.org/"
SUPPORT_URL="https://bbs.archlinux.org/"
BUG_REPORT_URL="https://gitlab.archlinux.org/groups/archlinux/-/issues"
PRIVACY_POLICY_URL="https://terms.archlinux.org/docs/privacy-policy/"
LOGO=archlinux-logo


plugins:

Description

The last version of Hyprland (tested on commit c9822b0) shows artifacts and flickers in games with V-Sync enabled (seems like normal apps have artifacts too). Changing VRR and lowering monitor refresh-rate does not help. Downgrading to tag v0.46.2 solves the problem. Videos exposing the difference are attached.

How to reproduce

trying to bisect now, will update soon.

1. Checkout 6a90b50
2. Run any game to see artifacts, turn on V-Sync to get flickering when moving camera

Attach not paste

• I understand that all text files must be attached, and not pasted directly. If not respected, this issue will likely get closed as spam

Checklist of files to include below

• Hyprland config - hyprctl systeminfo -c (always include)
• Crash report (always include in case of crash)
• Video (always include in case of a visual bug)
• Logs (might contain useful info such as errors)

Additional info & File uploads

hyprland_config_dump.txt
hyprland.log
hyprland_dump.txt
http://gulag.cybercommunity.space/2025-01-09%2020-17-09.mkv
http://gulag.cybercommunity.space/2025-01-09%2020-50-22.mkv

UPD: After bisecting, the commit 6a90b50 appeared to be the reason

[arsenez2006]

Seems like my issue is very close to #8983

[vaxerski]

can you try removing the comments as mentioned in 8983?

[UjinT34]

I have this flickers in minecraft even with those buffer drops. Hard to test reliably. Seems to happen only when going to unexplored areas. Very frequent flickers in a new world which vanish over time if you stay in an explored area. Less severe or completely unnoticeable in fullscreen with vrr on. Happens more frequently with in game vsync on. Unlimited fps has less frequent flickers. Any other in game fps limit might remove the flickering. Open areas tend to trigger it more often. Looks like a minecraft issue or something unrelated to #8966.
If it is related to the buffer drop changes than wine/proton games shouldn't be affected. They are usually forced to use triple buffering. At least I don't get any issues in such games.

[arsenez2006]

can you try removing the comments as mentioned in 8983?

diff --git a/src/protocols/core/Compositor.cpp b/src/protocols/core/Compositor.cpp
index 6213f987..e7ff00bf 100644
--- a/src/protocols/core/Compositor.cpp
+++ b/src/protocols/core/Compositor.cpp
@@ -450,8 +450,8 @@ void CWLSurfaceResource::commitPendingState() {
         // release the buffer if it's synchronous as update() has done everything thats needed
         // so we can let the app know we're done.
         // Some clients aren't ready to receive a release this early. Should be fine to release it on the next commitPendingState.
-        // if (current.buffer->buffer->isSynchronous())
-        //     dropCurrentBuffer();
+        if (current.buffer->buffer->isSynchronous())
+            dropCurrentBuffer();
     }
 
     // TODO: we should _accumulate_ and not replace above if sync
diff --git a/src/render/shaders/Textures.hpp b/src/render/shaders/Textures.hpp
index 49d27b4c..78845322 100644
--- a/src/render/shaders/Textures.hpp
+++ b/src/render/shaders/Textures.hpp
@@ -19,7 +19,7 @@ inline static constexpr auto ROUNDED_SHADER_FUNC = [](const std::string colorVar
     const float SMOOTHING_CONSTANT = )#" +
         std::format("{:.7f}", SHADER_ROUNDED_SMOOTHING_FACTOR) + R"#(;
 
-    //if (pixCoord.x + pixCoord.y > radius) {
+    if (pixCoord.x + pixCoord.y > radius) {
 
 	      float dist = pow(pow(pixCoord.x, roundingPower) + pow(pixCoord.y, roundingPower), 1.0/roundingPower);
 
@@ -30,7 +30,7 @@ inline static constexpr auto ROUNDED_SHADER_FUNC = [](const std::string colorVar
 
 	      )#" +
         colorVarName + R"#( = )#" + colorVarName + R"#( * normalized;
-    //}
+    }
 )#";
 };
 

Minecraft still fliсker and the camera twitches. Also I remember that osu-lazer had rare flickers, but now i can't reproduce them even with V-Sync on, will try to comment back this lines and report soon.

[arsenez2006]

Commenting back returned rare flickers in osu-lazer

[caffeine01]

I was also experiencing some flickers in osu-lazer. the first time i saw flickers was due to direct scanout issues due to me being dumb a while ago, but this is unrelated now.
Its like, some UI elements will just flicker in brightness?
Also, some weird flickering shit happens with the UI of some apps:

2025-01-10.14-58-23.mp4

you see that shit? thats odd.

[caffeine01]

Further evidence within osu!lazer

2025-01-11.16-20-31.mp4