Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function to convert OEB's assessment.json to table for OEB independent plots #376

Closed
ninsch3000 opened this issue Jul 8, 2022 · 1 comment · Fixed by #381
Closed

Function to convert OEB's assessment.json to table for OEB independent plots #376

ninsch3000 opened this issue Jul 8, 2022 · 1 comment · Fixed by #381
Assignees
Labels
enhancement New feature or request high priority

Comments

@ninsch3000
Copy link
Collaborator

ninsch3000 commented Jul 8, 2022

Problem

Currently, all calculated metrics are written to an assessment_datasets.json file for each tool. In order to plot summary statistics outside OEB we'll sooner or later need to convert the json format into a table/dataframe, in order to tackle issues #245 #290

Possible solutions

  1. Write tsv files in parallel to the assessment json file in compute_metrics.py
  • advantage: if metric names change in a way that requires changes in parsing, this can be taken care of in the same script
  • disadvantage: script compute_metrics.py gets even more crowded
  1. Read assessment json and convert to tsv; module in utils directory.
  • advantage: clean structure, clear separation of functions
  • disadvantage: if metric names change, parsing might be broken; debugging/updating more difficult to track

Other suggestions welcome!

If you have an opinion please comment 🙏

@ninsch3000 ninsch3000 added enhancement New feature or request high priority labels Jul 8, 2022
@ninsch3000 ninsch3000 self-assigned this Jul 13, 2022
@ninsch3000
Copy link
Collaborator Author

Thanks for voting, solution 2 it is ;)

@ninsch3000 ninsch3000 mentioned this issue Jul 14, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant