convert warns for greyscale captures

[saturnism]

sometimes screencapture saves png file that's greyscale (e.g., black white console). when this happens, convert will complain and warn about not being able to convert colors space:

https://github.com/icholy/ttygif/blob/master/ttygif_osx.c#L125

It helps to disable warning by redirecting it to /dev/null

[icholy]

Does it prevent it from creating the output gif?

[saturnism]

Yeah - the generated gif has the warning all over
On Mon, Jul 13, 2015 at 19:19 Ilia Choly [email protected] wrote:

Does it prevent it from creating the output gif?

—
Reply to this email directly or view it on GitHub
#35 (comment).

[icholy]

Do you have an example I can see?

[saturnism]

[icholy]

Oh, I see what you mean. Can I get a few of the pngs that you're using?

http://stackoverflow.com/a/11451064/215969

identify -format "%[colorspace]   <== %f\n" *.png

[saturnism]

The pngs are generated by ttygif afaik.
On Tue, Jul 14, 2015 at 12:31 Ilia Choly [email protected] wrote:

Oh, I see what you mean. Can I get a few of the pngs that you're using?

http://stackoverflow.com/a/11451064/215969

identify -format "%[colorspace] <== %f\n" *.png

—
Reply to this email directly or view it on GitHub
#35 (comment).

[icholy]

Someone else contributed the osx version which uses screencapture. I'm on linux so I have no way to test/reproduce this issue.

If you give me an example png that creates the problem I'll try to find appropriate flags for convert to handle it correctly.

I don't want to pipe the output to /dev/null because that might hide real errors in the future.

[rzh]

There is a workaround for this, make your terminal full screen and run ttygif with -f option. works for Mac OS's native terminal.app, did not try iTerm.

I think the issue is caused by this line
https://github.com/icholy/ttygif/blob/master/ttygif_osx.c#L125

[jonbho]

I just wrote a fix for this and submitted a pull request for this, by redirecting error output, before reading that you didn't want to do that. Sorry.

It does fix it completely, because convert just complains but it still processes things correctly. Removing "-background white" from the convert argument list also fixes it.

Personally, the call to convert says "-quiet", so it specifically doesn't want error messages. I'd say it is a bug in "convert" not to honor the "-quiet" argument. And if you tell it "-quiet", I see no harm in just redirecting the output to null - there is clearly an interest in not getting any output.

Proper fixes would require proper command-line args to ttygif, which is still quite a bit of effort to add.

Otherwise thanks for the awesome work!