Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seg fault on using the Mesh system with the Components system #29667

Open
GiudGiud opened this issue Jan 9, 2025 · 0 comments · May be fixed by #29668
Open

Seg fault on using the Mesh system with the Components system #29667

GiudGiud opened this issue Jan 9, 2025 · 0 comments · May be fixed by #29668
Assignees
@GiudGiud
Labels
C: Modules/Thermal Hydraulics Tickets pertaining to the thermal_hydraulics module P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.

Comments

@GiudGiud
Copy link
Contributor

GiudGiud commented Jan 9, 2025 •
edited
Loading

Bug Description

When creating a regular mesh or using mesh generators and at the same time adding components which rely on the mesh being a THMMesh rather than a MooseMesh, we currently seg-fault.

We possibly could support this if we make THMMesh inherit from the GeneratedMesh. but for now we should just have a clean error

Steps to Reproduce

Run this input

[Mesh]
  type = GeneratedMesh
  dim = 1
  nx = 1
[]

[Variables]
  [u]
  []
[]

[Kernels]
  [diff]
    type = CoefDiffusion
    variable = u
    coef = 0.1
  []
  [time]
    type = TimeDerivative
    variable = u
  []
[]

[Components]
  [inlet]
    type = InletMassFlowRateTemperature1Phase
    input = 'iwst_pipe_1:in'
    m_dot = ${m_dot_in}
    T = ${T_in}
  []

  [iwst_pipe_1]
    type = FlowChannel1Phase
    position = '0 0 0'
    orientation = '0 1 0'
    length = 10
    n_elems = 15
    A = ${A_pipe}
    D_h = ${pipe_dia}
  []

    [outlet]
      type = Outlet1Phase
      input = 'iwst_pipe_1:out'
      p = ${pressure}
  []
[]

[Executioner]
  type = Transient
  dt = 0.1
  num_steps = 10
  abort_on_solve_fail = true
[]

Impact

Looks untidy though no real impact.

[Optional] Diagnostics

No response
@GiudGiud GiudGiud added T: defect An anomaly, which is anything that deviates from expectations. P: normal A defect affecting operation with a low possibility of significantly affects. C: Modules/Thermal Hydraulics Tickets pertaining to the thermal_hydraulics module labels Jan 9, 2025
@GiudGiud GiudGiud self-assigned this Jan 9, 2025
GiudGiud added a commit to GiudGiud/moose that referenced this issue Jan 9, 2025
@GiudGiud
Add a clean error on adding components with a regular / mesh generate…
25e7f55 
…d mesh

closes idaholab#29667
@GiudGiud GiudGiud linked a pull request Jan 9, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GiudGiud GiudGiud

Labels
C: Modules/Thermal Hydraulics Tickets pertaining to the thermal_hydraulics module P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a clean error on adding components with a regular / mesh generated mesh GiudGiud/moose
1 participant
@GiudGiud