Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Google Guava for public suffix API #12

Closed
anjackson opened this issue Oct 26, 2013 · 2 comments
Closed

Switch to Google Guava for public suffix API #12

anjackson opened this issue Oct 26, 2013 · 2 comments

Comments

@anjackson
Copy link
Member

While porting for #10, this happened:

One issue I noticed was that the archive-access code brings in entire heritrix-commons just for one class, which appears to be quite general purpose:

import org.archive.net.PublicSuffixes;

(indeed, there is a Google Guava class that does pretty much the same thing). This seems a little over the top, so I copied the PublicSuffixes to iipc-web-commons under the org.archive.url package, along with the corresponding unit tests and effective_tld data file.

This is rather clumsy, and given this is provided by Google Guava, there seems little point maintaining our own code (assuming theirs is kept up to date). The task is then to check that the Google one is well maintained and switch over to that instead of copying in code from elsewhere.

@anjackson
Copy link
Member Author

This actually turned in via iipc/webarchive-commons#1, and should be moved there.

@anjackson
Copy link
Member Author

Re-filed as iipc/webarchive-commons#4.

nlevitt added a commit to nlevitt/openwayback that referenced this issue Apr 2, 2014
RogerMathisen pushed a commit to nlnwa/openwayback that referenced this issue Sep 23, 2014
configure properties so sonatype repositories are defaults for distribut...
RogerMathisen pushed a commit to nlnwa/openwayback that referenced this issue Sep 23, 2014
Check WARC/GZ via file extension
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant