Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Got here from optipng-bin, which says I want to use this... but why? #25

Open
Pomax opened this issue Mar 24, 2020 · 4 comments
Open

Got here from optipng-bin, which says I want to use this... but why? #25

Pomax opened this issue Mar 24, 2020 · 4 comments

Comments

@Pomax
Copy link

Pomax commented Mar 24, 2020

https://github.com/imagemin/optipng-bin says "You probably want imagemin-optipng instead" but I don't see anything that shows this can be used as CLI utility.... why should we want to use this?

@ogonkov
Copy link

ogonkov commented Apr 3, 2020

I guess optipng-bin is low-level package that is not recommended for direct use. This package looks like user-friendly wrapper for optipng-bin.

@Pomax
Copy link
Author

Pomax commented Apr 3, 2020

Guesses don't help people understand why they're being told to switch package. Low level is fine for automated cleanup, so the original question remains: why is the readme.md saying what it says?

@1000ch
Copy link
Contributor

1000ch commented Jun 4, 2020

optipng-bin is a low-level module, and imagemin-optipng provides a nicer interface by wrapping optipng-bin. Which we want to use depends on our use-case, so it says "You probably want imagemin-optipng instead."

@Pomax
Copy link
Author

Pomax commented Jun 4, 2020

Right, but this is an npm package, hosted on github, and uses signaling akin to what people use to indicate that a package is deprecated. Rather than saying "you probably want to use X" (which in the context of an npm package has come just be a polite way to say "stop using this") it would be better to add a heading an one or two paragraphs that explain when you want to use optipng-bin, and when it makes more sense to use imagemin-optipng.

We use it for CLI cleaning of PNG files, for instance, where we definitely don't want a more elaborate interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants