Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet): rebrand top bar #1775

Merged
merged 11 commits into from
Aug 14, 2024
Merged

feat(wallet): rebrand top bar #1775

merged 11 commits into from
Aug 14, 2024

Conversation

evavirseda
Copy link
Contributor

Description of change

Please write a summary of your changes and why you made them.

Links to any relevant issues

fixes #1753

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@evavirseda evavirseda self-assigned this Aug 13, 2024
@evavirseda evavirseda added the tooling Issues related to the Tooling team label Aug 13, 2024
@evavirseda evavirseda marked this pull request as ready for review August 13, 2024 13:12
@evavirseda evavirseda requested review from a team as code owners August 13, 2024 13:12
@panteleymonchuk panteleymonchuk self-requested a review August 14, 2024 11:37
panteleymonchuk
panteleymonchuk reviewed Aug 14, 2024
View reviewed changes
Copy link
Contributor

@panteleymonchuk panteleymonchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

@begonaalvarezd begonaalvarezd requested a review from a team as a code owner August 14, 2024 16:51
@begonaalvarezd begonaalvarezd merged commit 1aa68f5 into develop Aug 14, 2024
23 checks passed
@begonaalvarezd begonaalvarezd deleted the tooling-wallet/rebrand-topnavbar branch August 14, 2024 17:10
bingyanglin pushed a commit that referenced this pull request Aug 19, 2024
@evavirseda @begonaalvarezd @bingyanglin
feat(wallet): rebrand top bar (#1775)
3c2dc8e 
* feat: first steps updating top header

* feat: use ledger icon

* feat: add locked feature

* feat: fix background

* refactor: unify link

* revert: sdk/move-bytecode-template/Cargo.lock

---------

Co-authored-by: Begoña Alvarez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panteleymonchuk panteleymonchuk panteleymonchuk approved these changes

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

Assignees

@evavirseda evavirseda

Labels
tooling Issues related to the Tooling team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task (tooling/wallet)]: Rebrand top bar
3 participants
@evavirseda @begonaalvarezd @panteleymonchuk