Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service- und Actionclients missing in templates #11

Open
abubeck opened this issue Apr 24, 2013 · 1 comment
Open

Service- und Actionclients missing in templates #11

abubeck opened this issue Apr 24, 2013 · 1 comment

Comments

@abubeck
Copy link
Contributor

abubeck commented Apr 24, 2013

While code for action and serviceservices is generated, the templates are missing implementations of clients.
Both for c++ and python templates.

@floweisshardt
Copy link
Member

it is important to have the clients generate from the model. If we let the user do that, we might get problems with remapping later on (if the names in the code don't fit the names in the model).

Simple solution: we could just add the client in the init/constructor function to make sure the name fits to the model:
cpp:
{{{actionlib::SimpleActionClient<learning_actionlib::FibonacciAction> ac("fibonacci", true);}}}
python
{{{self.client = actionlib.SimpleActionClient('fibonacci', actionlib_tutorials.msg.FibonacciAction)}}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants