error with custom Public Gateway URL http://ip:port

[waseemjaved755]

Checklist

• I am reporting a documentation issue in this repo, not https://docs.ipfs.tech.
• I have searched on the issue tracker for my issue.

Location

No response

Description

[lidel]

@SgtPooki thoughts? looks likecustomizing gateway via Settings Screen input loses port info?

[SgtPooki]

it does look like port is being dropped @lidel I can look into this

[SgtPooki]

definitely dropping the port, error is here:

ipfs-webui/src/bundles/gateway.js

Lines 138 to 139 in 878975a

	imgSubdomainUrl = new URL(`${gwUrl.protocol}//${IMG_HASH_1PX}.ipfs.${gwUrl.hostname}/?now=${Date.now()}&filename=1x1.png#x-ipfs-companion-no-redirect`)
	imgRedirectedPathUrl = new URL(`${gwUrl.protocol}//${gwUrl.hostname}/ipfs/${IMG_HASH_1PX}?now=${Date.now()}&filename=1x1.png#x-ipfs-companion-no-redirect`)

[SgtPooki]

A few things:

1. We are currently checking that both a subdomain url will work, so IP:port from OP won't work, that's an invalid URL. see

   ipfs-webui/src/bundles/gateway.js

   Line 144 in 878975a

   return await checkViaImgUrl(imgSubdomainUrl)

2. We also check that path URLs redirect to subdomains see

   ipfs-webui/src/bundles/gateway.js

   Line 145 in 878975a

   .then(async () => expectSubdomainRedirect(imgRedirectedPathUrl))

---

potential fixes here:

• display an error to users if they enter an ip address with port, it is invalid
• don't check for subdomains (wouldn't this invalidate the whole change of fix(files): prefer subdomain gw in copied share links #2255)
• display more information in the description for this input that ip:port URLs will not work, and that the URL must support the format {protocol}://{cid}.ipfs.{host}

[lidel]

Thank you for looking into this.

@waseemjaved755 seem to be using older version which had a single setting. since then we've split it into two.

I think we should:

1. add input validation and refuse setting IP-based URL as Subdomain gateway.
2. make sure IP-only URLs are allowed for Path gateway, but also make sure that port is respected