Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wpt #131

Merged
merged 3 commits into from
Jun 8, 2024
Merged

Fix wpt #131

merged 3 commits into from
Jun 8, 2024

Conversation

b-ma
Copy link
Collaborator

@b-ma b-ma commented Jun 7, 2024

This fixes some issues that were introduced by AudioWorklet (cf. getElementByTagName spam, 100% CPU, etc.)

|| name.includes('the-channelmergernode-interface/active-processing.https.html')
// timeout, but when test is fixed, trigger a segfault
// should be fixed with https://nodejs.org/api/worker_threads.html#workermarkasuntransferableobject
|| name.includes('the-audioworklet-interface/audioworkletprocessor-process-frozen-array.https.html')
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that these additions are fixed and removed in the next PR

Copy link
Collaborator

@orottier orottier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay great. I still see some errors getElementByTagName in wpt/webaudio/the-audio-api/the-audioworklet-interface/audioworkletprocessor-options.https.html but the rest is gone!

@b-ma b-ma merged commit 6922621 into main Jun 8, 2024
5 checks passed
@b-ma b-ma deleted the fix/wpt branch June 8, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants