Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the viewer mobile friendly #4

Open
opeeters opened this issue Dec 18, 2019 · 2 comments
Open

Make the viewer mobile friendly #4

opeeters opened this issue Dec 18, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@opeeters
Copy link
Member

e.g.:

  • let timechanger take entire width with attribution & download button just above
  • collapse leaflet-control-layers

... ideas very welcome

@opeeters opeeters added the enhancement New feature or request label Dec 18, 2019
@opeeters opeeters added this to the 0.1.2 milestone Dec 19, 2019
@stevenvdbosch
Copy link
Collaborator

stevenvdbosch commented Jan 9, 2020

On top of your suggestions:

  • for timechanger, maybe only take entire width when the width of the page is below a threshold. If i hold my phone horizontally it seems pretty ok?
  • Maybe let's rename the download button in all cases to "Downloads" (takes less space). and align to the right side (didn't have time previously to make that part prettier)
  • We could also redesign a bit the download container as a pop up window:
    • download button becomes a button with a download icon (we could even put the button then on the left upper side like most buttons
    • it triggers a popup window for the downloads.
      => do you think this is nicer or more disturbing for the user?

Other problems:

  1. The Legend button which is in front of the timechanger. We could try to put the legend button above the timechanger
  2. When holding your phone vertically, the SVG of the legend is cut of, i don't know how to deal with that one. You could say somehow let it shrink but i think you wont be able to read the letters.
    svg_image_cut_off

What do you think

@opeeters
Copy link
Member Author

opeeters commented Jan 10, 2020

@stevenvdbosch

  • yes, on a horizontal smartphone it looks fine
  • done: 775b025
  • Oh, previous commit was not really necessary :-) Icon is a good idea (with a i18N tooltip)
  • a pop-up window with room for more explanation would be best in my opinion
  1. fine
  2. maybe switch to a landscape legend (cf https://www.irceline.be/air/legend/index_EN_landscape.svg - still need to make landscape versions for most aggregations/pollutants) at width:100%?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants