Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make --tracking off by default #121

Open
jfinken opened this issue Aug 24, 2023 · 1 comment
Open

Make --tracking off by default #121

jfinken opened this issue Aug 24, 2023 · 1 comment

Comments

@jfinken
Copy link
Contributor

jfinken commented Aug 24, 2023

Given CPU performance implications, turn event tracking off by default.

  • I believe that would simply be setting this to false but correct me if I'm wrong
  • If correct, I'd be happy to submit a quick PR. Please let me know the correct destination branch.
@alsora
Copy link
Collaborator

alsora commented Aug 25, 2023

Yes, that's the line to change.
I would say to target master for now. We can figure out what to do with the branches as a separate effort and, if needed, cherry-pick the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jfinken @alsora